mrdee 1 Report post Posted November 2, 2007 I got my mail() function to work on my local machine, thanks to jhaslip's excellent help. (Sincere thanks for that).Now, I am one step away from completing a script to let it do exactly what I want.I already have a page where people can fill in a form to subscribe to a newsletter, and they get an email to confirm they have subscribed.However, i would like to be able to put a link in there, when they click on it it sends them to a webpage to tell them their subscription is now active.To achieve that, i have added one field to the table called 'active', with an array type of int(1) and set to a default of 0.The only thing I want now is that when people click the link, it sets the value of 'active' to 1 and takes them to a page confirming this has happened and their subscription is now active.Unfortunately, I am not 100% sure of how to set up the link (probably something like "http://forums.xisto.com/no_longer_exists/) or the code to change the 'active' value for that particular record to 1.BTW my table 'newsletter' looks like: id int(1) auto_increment primary index, first Varchar(30), last varchar(30), town varchar(30), country varchar(30), email varchar(60), active int(1) default 0.All fields are NOT NULL.Any suggestions, please?Thanks in advance. Share this post Link to post Share on other sites
jlhaslip 4 Report post Posted November 2, 2007 http://forums.xisto.com/no_longer_exists/;'>http://forums.xisto.com/no_longer_exists/; The "something" would be their Registration id so you know who is submitting the confirmation.http://forums.xisto.com/no_longer_exists/ Then have the confirm.php use the confirm_id value of the query string to find the member by id and alter the confirm code to 'true' Share this post Link to post Share on other sites
mrdee 1 Report post Posted November 3, 2007 Thanks, but there are weird things going on.This is my listing for signing in: <HTML><HEAD> <TITLE>Vlaanderen-Flanders</TITLE></HEAD><BODY><?php$con = mysql_connect("localhost","root","********");if (!$con) { die('Could not connect: ' . mysql_error()); }$First = trim(addslashes(strip_tags($_POST['First'])));$Name = trim(addslashes(strip_tags($_POST['Name'])));$Town = trim(addslashes(strip_tags($_POST['Town'])));$Country = trim(addslashes(strip_tags($_POST['Country'])));$Email = trim(addslashes(strip_tags($_POST['Email'])));mysql_select_db("tester", $con);mysql_query("INSERT INTO newsletter VALUES ('','$First','$Name','$Town','$Country','$Email')") or die(mysql_error());mysql_close($con);$email_address_to = "$Email";$site = "http://vlaanderen-flanders.org.uk;;$subject = "Thank you";$message_contents = "Hello, $First, Thank you for subscribing to our newsletter.\n Click the link below to confirm your subscription:\n http://localhost/home/confirm.php?confirm_id=9806 \n Kind regards,\n The webmaster.\n $site\n";$header = "From: webbie@vlaanderen-flanders.org.uk\r\n";$header .= "Reply-To: webbie@vlaanderen-flanders.org.uk\r\n";$header .= "webbie@vlaanderen-flanders.org.uk\r\n";mail($email_address_to,$subject,$message_contents,$header);?><div align="center"><img src="Pics/Vlaamse Leeuw.jpg" width="114" height="127" alt="" border="0" align=""></div><p align="center"><b>Thank you, you have subscribed and you will receive a confirmation email soon.</b></p><br><p align="center"><a href="index.htm"><img src="Pics/begin.gif" width="95" height="30" border="0"></a></p></BODY></HTML>This worked before for subscribing, now I am getting : 'Column count doesn't match value count at row 1' from this PHP page.If that is relevant, the first field is simply called 'id', and is int(6) with auto_increment.Also, to get to that page, a form has been filled in on a HTML page, the following fields were submitted: First, Name, Town, Country, Email.Thanks for all the help so far. Share this post Link to post Share on other sites
jlhaslip 4 Report post Posted November 3, 2007 mysql_query("INSERT INTO newsletter VALUES ('','$First','$Name','$Town','$Country','$Email')Count the number of fields you are INSERTing, and compare it to the number of fields in the Table.I think you might've forgot to INSERT a value for the 'active int(1)'. Add a pair of single quotes, if nothing else, then it should assume the default value of '0' (false).mysql_query("INSERT INTO newsletter VALUES ('','$First','$Name','$Town','$Country','$Email', '') Share this post Link to post Share on other sites
mrdee 1 Report post Posted November 3, 2007 Sorry to bother you again, but still not getting there with the following in confirm.php: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://forums.xisto.com/no_longer_exists/ xmlns="http://forums.xisto.com/no_longer_exists/ http-equiv="Content-Type" content="text/html; charset=utf-8" /><title>Untitled Document</title></head><body><?php$con = mysql_connect("localhost","root","root");if (!$con) { die('Could not connect: ' . mysql_error()); } mysql_select_db("tester", $con); $confirm_id=9806;mysql_query("UPDATE newsletter SET active='1' WHERE $confirm_id='$id'") or die(mysql_error());mysql_close($con);echo 'That\'s it!!!';?></body></html> I have had all sorts of errors, from parsing errors to unidentified variables, and the latest one is this: 'Notice: Undefined variable: id in c:\program files\easyphp1-8\home\confirm.php on line 17'.So, I am obviously still doing something wrong. Thanks. Share this post Link to post Share on other sites
mrdee 1 Report post Posted November 4, 2007 I assume confirm_id is a variable? Is that correct?And why exactly is the value 9806?Will that be the value for every confirmation of members?And what is the relationship of config_id (which holds 9806) to the id field in the database?That is where I really get stuck, getting that particular record of the person who clicked the confirm link, in order to set his activation to 1 (true).I really don't see how to do it.Thanks. Share this post Link to post Share on other sites
sonesay 7 Report post Posted November 5, 2007 In your first page you are inserting records into a database mysql_query("INSERT INTO newsletter VALUES ('','$First','$Name','$Town','$Country','$Email','')") or die(mysql_error()); from the above code:VALUES ('' is the key you want to retrive and use to distinguish between each unique user and use it in confirm.php later to set the 'active' field for when users subscribe. So you will need to get this key(id) somehow to be able to use it in confirm.php. i dont think mysql stored it after executing an insert query you may have to do an additional query to retrieve it. maybe something like(if the key is called id)} linenums:0'>$result = mysql_query("Select id from newsletter where email =". $Email);while($row = mysql_fetch_array($result)){ $confirm_id = $row['id'];}Then when the key is set you can use it"Hello, $First, Thank you for subscribing to our newsletter.\n Click the link below to confirm your subscription:\n [url="LOCALHOST/home/confirm.php?confirm_id=""]http://localhost/home/confirm.php?confirm_id="[/url]. $confirm_id." \n Kind regards,\n The webmaster.\n $site\n"; This line here where you do the update is wrongmysql_query("UPDATE newsletter SET active='1' WHERE $confirm_id='$id'") or die(mysql_error());$id not defined and you do not need to because you want to insert into id not assign id to $confirm_id in a sql statement.so it should be something like thismysql_query("UPDATE newsletter SET active='1' WHERE id = '".$confirm_id."'") or die(mysql_error()); Share this post Link to post Share on other sites
mrdee 1 Report post Posted November 7, 2007 Thanks,but I keep getting errors all over the place.Ultimately, the code for confirm.php changed to this: <HTML><HEAD> <TITLE>Vlaanderen-Flanders</TITLE></HEAD><BODY><?php$con = mysql_connect("localhost","root","*************");if (!$con) { die('Could not connect: ' . mysql_error()); }$Voornaam = trim(addslashes(strip_tags($_POST['First'])));$Naam = trim(addslashes(strip_tags($_POST['Name'])));$Stad = trim(addslashes(strip_tags($_POST['Town'])));$Land = trim(addslashes(strip_tags($_POST['Country'])));$Epost = trim(addslashes(strip_tags($_POST['Email'])));mysql_select_db("tester", $con);mysql_query("INSERT INTO newsletter VALUES ('','$First','$Name','$Town','$Country','$Email','')") or die(mysql_error());$result = mysql_query("Select id from newsletter where Email=('$Email)");while($row = mysql_fetch_array($result)){$confirm_id = $row['id'];}mysql_close($con);$email_address_to = "$Email";$site = "http://vlaanderen-flanders.org.uk;;$subject = "Thanks";$message_contents = "Hello, $First, thank you for subscribing to our newsletter.\n Click the link below to confirm your subscription.\n http://localhost/home/confirm.php?confirm_id='$confirm_id' \n Kind regards,\n The webmaster.\n $site\n";$header = "From: webbie@vlaanderen-flanders.org.uk\r\n";$header .= "Reply-To: webbie@vlaanderen-flanders.org.uk\r\n";$header .= "webbie@vlaanderen-flanders.org.uk\r\n";mail($email_address_to,$subject,$message_contents,$header);?><div align="center"><img src="Pics/Vlaamse Leeuw.jpg" width="114" height="127" alt="" border="0" align=""></div><p align="center"><b>Thank you, you are now subscribed.</b></p><br><p align="center"><a href="index.htm"><img src="Pics/begin.gif" width="95" height="30" border="0"></a></p></BODY></HTML> I had to change in a few places where you did things like $result = mysql_query("Select id from newsletter where email =". $Email); as i got parse errors and all that.I think I am losing site of the trees through the woods with all the single and double quotes and parentheses and curly brackets and that.The last errors I got were those:Notice: Undefined variable: Email in c:\program files\easyphp1-8\home\confirm.php on line 16Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in c:\program files\easyphp1-8\home\confirm.php on line 18Notice: Undefined variable: First in c:\program files\easyphp1-8\home\confirm.php on line 22Notice: Undefined variable: confirm_id in c:\program files\easyphp1-8\home\confirm.php on line 22Notice: Undefined variable: site in c:\program files\easyphp1-8\home\confirm.php on line 22Notice: Undefined variable: confirm_id in c:\program files\easyphp1-8\home\confirm.php on line 24Notice: Undefined variable: id in c:\program files\easyphp1-8\home\confirm.php on line 24You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '=''' at line 1I am getting more and more confused now.Please try to give me further help.Thanks in advance. Share this post Link to post Share on other sites
sonesay 7 Report post Posted November 7, 2007 (edited) ok I'll try help out more. Dinner soon for me so when its done I'll edit this reply.Edit:Ok looking through the code you changed alot of names for the variables but didnt change them further down the code when you use them. $Voornaam = trim(addslashes(strip_tags($_POST['First'])));$Naam = trim(addslashes(strip_tags($_POST['Name'])));$Stad = trim(addslashes(strip_tags($_POST['Town'])));$Land = trim(addslashes(strip_tags($_POST['Country'])));$Epost = trim(addslashes(strip_tags($_POST['Email'])));mysql_select_db("tester", $con);mysql_query("INSERT INTO newsletter VALUES ('','$First','$Name','$Town','$Country','$Email','')") or die(mysql_error()); Change it to this and you wont get those undefined variable errors. $First = trim(addslashes(strip_tags($_POST['First'])));$Name = trim(addslashes(strip_tags($_POST['Name'])));$Town = trim(addslashes(strip_tags($_POST['Town'])));$Country = trim(addslashes(strip_tags($_POST['Country'])));$Email = trim(addslashes(strip_tags($_POST['Email'])));mysql_select_db("tester", $con);mysql_query("INSERT INTO newsletter VALUES ('','$First','$Name','$Town','$Country','$Email','')") or die(mysql_error()); The error you get from undefined confirm_id Notice: Undefined variable: confirm_id in c:\program files\easyphp1-8\home\confirm.php on line 22is because of $result Query failing. the following code should work. $result = mysql_query("Select id from newsletter where Email ='".$Email."'"); Edited November 7, 2007 by sonesay (see edit history) Share this post Link to post Share on other sites
